|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] Prevent unnatural use of ioctl in /proc/xen/xenbus_dev
On Fri, 2005-09-09 at 13:48 +0100, Keir Fraser wrote: > On 9 Sep 2005, at 12:29, Rusty Russell wrote: > > > xenbus_dev's use of ioctl for read/write is a crime against nature. > > Make it a read-write interface, but check boundaries so we can recover > > if userspace dies. This also simplifies libxenstore. > > How can you cleanly express the request/reponse nature of interacting > with xenstore, and grouping of accesses into transactions, via > read/write? Err... the same way we do when tools interact with the store over a pipe? Which is the same protocol we use in shared memory. > I would imagine you lose valuable framing information that > you end up having to reconstruct. The only painful part is that userspace is now hijacking the kernel's xenstore comms channel. While we clearly trust userspace somewhat, since they're using our ID for operations, we want to ensure that we have a usable channel if they die unexpectedly. Otherwise it would be entirely trivial... Rusty. -- A bad analogy is like a leaky screwdriver -- Richard Braakman _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |