[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] fix "make uninstall" so that it will remove files first


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Jerone Young <jyoung5@xxxxxxxxxx>
  • Date: Sat, 24 Sep 2005 00:57:21 -0500
  • Delivery-date: Sat, 24 Sep 2005 05:57:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

If anyone knows a better way to check for a file in make please reply to
this patch. The problem here is that when /etc/xen does not exist "[ -d
$(D)/etc/xen ]" (otherwise know as "test") return 1 and make bails out.
So I have moved this as the last task as a temporary fix.

Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx>
# HG changeset patch
# User root@xxxxxxxxxxxxxxxxxxxxxxxx
# Node ID 18994ae7c234f71d8ef994dcd12c6dcf1a748c42
# Parent  2f83ff9f6bd2a7987c297b84bfce1f8e22409cae
Change so that test for existance of /etc/xen is last. If the test fails
then the entire uninstall process fails and no file are removed.

diff -r 2f83ff9f6bd2 -r 18994ae7c234 Makefile
--- a/Makefile  Thu Sep 22 17:03:16 2005
+++ b/Makefile  Sat Sep 24 04:54:03 2005
@@ -164,7 +164,6 @@
 uninstall: DESTDIR=
 uninstall: D=$(DESTDIR)
 uninstall:
-       [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-`date
+%s`
        rm -rf $(D)/etc/init.d/xend*
        rm -rf $(D)/etc/hotplug/xen-backend.agent
        rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
@@ -185,6 +184,7 @@
        rm -rf $(D)/usr/share/xen
        rm -rf $(D)/usr/share/man/man1/xen*
        rm -rf $(D)/usr/share/man/man8/xen*
+       [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-`date
+%s`

 # Legacy targets for compatibility
 linux24:

-- 
Jerone Young
IBM Linux Technology Center
jyoung5@xxxxxxxxxx
512-838-1157 (T/L: 678-1157)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.