[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] 32/64-bit hypercall interface - padding

>>>>> "HB" == Hollis Blanchard <hollisb@xxxxxxxxxx> writes:

Nice idea but not sufficient cuz the pointer could be in the worng
place you probably want
  struct {
        char _pad[sizeof (u64) - sizeof (long)];
        vcpu_guest_context_t *ptr;
 } ctxt;

 HB> diff -r 85f92475b943 xen/include/public/dom0_ops.h
 HB> --- a/xen/include/public/dom0_ops.h        Mon Oct  3 18:14:02 2005
 HB> +++ b/xen/include/public/dom0_ops.h        Tue Oct  4 16:37:44 2005
 HB> @@ -99,7 +99,10 @@
 HB>      domid_t                   domain;
 HB>      u16                       vcpu;
 HB>      /* IN/OUT parameters */
 HB> -    vcpu_guest_context_t *ctxt;
 HB> +    union {
 HB> +        vcpu_guest_context_t *ptr;
 HB> +        u64 _;
 HB> +    } ctxt;
 HB>  } dom0_setdomaininfo_t;
 HB>  #define DOM0_MSR              15

 "I got an idea, an idea so smart my head would explode if I even
  began to know what I was talking about." -- Peter Griffin (Family Guy)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.