Re: [Xen-devel] [PATCH] Cleanup use of strlen() to check for empty string

[Jacob Gorm Hansen <jacobg@xxxxxxx>]

On 10/5/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
>
> On 4 Oct 2005, at 23:50, Jacob Gorm Hansen wrote:
>
> > I came across checks for strlen(s)==0 a few places in drivers/xen.
> > Here is a patch to fix that.
>
> Isn't your patch exactly equivalent? None of that code is time critical
> enough that a call to strlen matters.

It's just gross (looping over the entire length of a string just to
see if the first char is empty) that's all. Apply if you will.

Jacob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel