[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] network-bridge script support for multipleexternal interfaces

  • To: "Charles Duffy" <cduffy@xxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
  • Date: Fri, 14 Oct 2005 14:44:34 +0100
  • Delivery-date: Fri, 14 Oct 2005 13:41:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcXQwy0hOeE6wyQBTN+HEi9FnIuTLwAAKwTg
  • Thread-topic: [Xen-devel] [PATCH] network-bridge script support for multipleexternal interfaces

> The attached patch allows the network-bridge script to be 
> used to generate multiple bridges corresponding to different 
> physical interfaces. It adds a new parameter, "virtnum", used 
> to refer both to the loopback interface to be used and to set 
> defaults regarding the physical interface and bridge name.
> Thus, if one wishes to start xen-br0 on eth0 and xen-br1 on 
> eth1, one need only call:
> network-bridge start ## virtnum is 0 by default 
> network-bridge start virtnum=1

We need a way of controlling the set of paramters that network-bridge is
invoked with from xend-config.sxp. I'd be inclined just to list the
whole command line.

I'm not sure I like the idea of specifying 'virtnum'. 

I think it might be better to be able to tell xend to invoke the script
multiple times e.g. :

(network-script "network-bridge netdev=eth0 bridge=xenbr0;
network-bridge netdev=eth1 bridge=xenbr1")

xend will need to insert "start"/"stop" into these lines as appropriate.
Possibly we should modify the scripts to take foo=bar parameters before
or after the start/stop command. 

NB: Note that I'm using xenbr0 rather than xen-br0. We need to remove
the hyphen as it plays havoc with certain vendor's scripts.

What do you think? Could you knock up a patch?

> ...well, that and set loopback.nloopbacks=2 in the Dom0 
> kernel parameters.

I think we should create two devices by default. They don't cost much
and you can't buy servers with <2 interfaces.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.