[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] Re: new gnttab_end_foreign_access?
- To: NAHieu <nahieu@xxxxxxxxx>
- From: Christopher Clark <christopher.clark@xxxxxxxxxxxx>
- Date: Thu, 3 Nov 2005 22:55:21 +0000
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 03 Nov 2005 22:55:41 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:references; b=ftNLKLwacNljQDThYcq+CuHzAbEpQcR3nJujAxSGNlP8G6djiKTizizFo7nkZpE4Wj44m2mplKaGsy2idXrbmLTdTBwgiwFHkPF8AEveaGVik8GOLjkjRTIETuW9eznSIyM2tU3C7t8aCgLCzpnxe5OfVnXvdElw1Rwixg5scSQ=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
The readonly arg isn't used but was originally intended to allow you to
drop a grant from allowing readwrite access to just readonly.
Haven't had a look at the new interface changes yet.
Christopher
On 11/3/05, NAHieu <nahieu@xxxxxxxxx> wrote:
On 11/3/05, NAHieu <nahieu@xxxxxxxxx> wrote:
> I have one more question:why gnttab_end_foreign_access_ref(grant_ref_t
> ref, int readonly) needs the "readonly" arg?
>
> Is gnttab_end_foreign_access_ref(grant_ref_t ref) not OK?
>
I took another look, and it seems we should remove "readonly" arg of
gnttab_end_foreign_access*, as they are not in use.
So those API should be:
int gnttab_end_foreign_access_ref(grant_ref_t ref);
void gnttab_end_foreign_access(grant_ref_t ref, unsigned long page);
I still have some doubt about the "page" arg, however.
Thanks
Hieu
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
