[Xen-devel] [PATCH] Make xm long list consistent with the store

[Dan Smith <danms@xxxxxxxxxx>]

This patch changes the XendDomainInfo.sxpr() function to get its
device information from the store, instead of the info['device']
list.  Instead of trying to keep this bit of internal state consistent
with the store, I think it's better to just use the store data
directly.  This makes the output of "xm list --long" always reflect
the current configuration in the store.

With this patch, the only two tests that fail are the following (which
have been failing recently):

 FAIL: 12_block_attach_shared_domU
         Bug #331 Started a DomU with write access to an in-use block device

XFAIL: 03_network_attach_detach_multiple_pos
        Unknown reason

# HG changeset patch
# User dan@xxxxxxxxxxxxxxxxxxxxxxxxxxx
# Node ID c3509a42d8bbfba3a855cf606fbc64766fbe5dbe
# Parent  ca236a81729dd31c9eab7991562dd1664ceb0abf
Make "xm list --long" generate device configuration data from xenstore state
instead of internal xend state.
Signed-off-by: Dan Smith <danms@xxxxxxxxxx>

diff -r ca236a81729d -r c3509a42d8bb tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Thu Dec  1 19:23:07 2005
+++ b/tools/python/xen/xend/XendDomainInfo.py   Thu Dec  1 21:23:29 2005
@@ -968,9 +968,9 @@
         if self.infoIsSet('image'):
             sxpr.append(['image', self.info['image']])
 
-        if self.infoIsSet('device'):
-            for (_, c) in self.info['device']:
-                sxpr.append(['device', c])
+        for cls in controllerClasses:
+            for config in self.getDeviceConfigurations(cls):
+                sxpr.append(['device', config])
 
         def stateChar(name):
             if name in self.info:

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel