[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH] VMX domain should call domain_crash_synchronous instead of domain_crash


  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Sun, 4 Dec 2005 12:13:29 +0800
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Sun, 04 Dec 2005 04:13:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcX4KpA5MLtifPk8QfeVcvkwSmL8ggAWNRrg
  • Thread-topic: [Xen-devel] [PATCH] VMX domain should call domain_crash_synchronous instead of domain_crash

>> VMX domain should call domain_crash_synchronous instead of 
>> domain_crash.
>> Since domain_crash will return at last, VMX domain should not use it.
>
>Sometimes delaying the crash is the right thing to do, if you are in a 
>context with locks held (for example). You will still stop executing 
>before returning to guest context. Are you sure that all the changes 
>from domain_crash -> domain_crash_synchronous are correct?
>

Yes, they are correct.
For vmx domain, return of domain_crash will cause some unexpected code
gets executed, which may crashes xen HV.
-Xin

>  -- Keir
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.