Re: [Xen-devel] [PATCH] Add default netmask to vif-nat

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Thu, Dec 08, 2005 at 03:41:53PM -0500, James Dykman wrote:

> If vif-nat is passed an IP address "10.1.1.27" instead of "10.1.1.27/16", 
> bits is an empty string. This causes a syntax error on 
> line 89 while setting intmask, and another "Hotplug scripts not working" 
> error.
> 
> This patch adds a default value, though a case can be made for removing 
> intmask, vif_int, netmask, and network since they
> don't seem to be used for anything.

Well if they aren't used for anything, let's get rid of them!

It looks like they were needed when we were using ifconfig to bring up the
interface, but since we are now manually adding the routing information using
"ip route", then we don't need them.

Could you submit a patch removing the cruft, making sure that
ip="10.1.1.27/16" and ip="10.1.1.27" both work?  Thanks.  I don't think that
the former is meaningful in the vif-nat topology, but for backwards
compatibility it would be good if both forms worked.

Thanks,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel