Re: [Xen-devel] [PATCH] [XM-TEST] Add support for VMX guests in xm-test

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Wed, Dec 07, 2005 at 02:04:38PM -0800, Daniel Stekloff wrote:

> 
> Here's a patch to add initial support for vmx guests in xm-test. This
> patch applies to changeset 8272:b215584242c4.

I've applied this.  I would prefer it in the future if you could separate out
unrelated changes into different patches.  For example, you have removed the
unused __randomize facility from XmTestDomain with this patch.  Removing it is
a useful thing to do, and appreciated, but it's not related to VMX guest
support, so it would be better if you could provide such things as separate
patches in the future.

That said, VMX support for xm-test is a good idea, and your work is gratefully
received.

> I've run it on both vmx and non-vmx guests. I got the following report
> for running with vmx enabled:
> 
> Xm-test execution summary:
>   PASS:  69
>   FAIL:  23
>   XPASS: 0
>   XFAIL: 1

Do we have an idea as to the nature of these failures?  Are these things that
will never be testable or implementable due to the nature of VMX domains, or
are these failures, plain and simple?

I would like to see a separate XFAIL_TESTS_VMX or something like that, so that
we can indicate which tests currently fail on VMX, and a separate
DISABLED_TESTS_VMX to indicate those that will never pass on VMX.  What do you
think?

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel