Re: [Xen-devel] [PATCH][RESEND] add "acpi" option in xmexample.vmxconfig file

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 30 Dec 2005, at 01:52, Yu, Ke wrote:

> Rebase the patch due to its conflict with new changeset 8445.
> Would somebody apply it or give some comments? Thanks
The info block written by vmx builder is no longer merely vcpu 
information. Hence its name and the magic string at the start of the 
block are badly named.
I would like to see a more ACPI-styled table. At the moment, can you 
please define a struct something like the following (where the 
definition is available both to vmx builder and vmxassist -- I guess 
the struct may need to be copied in two different header files):
struct hvm_info_table {
    char signature[8]; /* "HVM INFO" */
    u32 length;
    u8 checksum;
    u8 acpi_enabled;
    u8 pad[2];
    u32 nr_vcpus;
};

Where the checksum is a simple ACPI-style twos-complement byte 
summation and test for zero.
This has the advantages of a meaningful name and gets rid of magic 
numbers (indexes into array of unsigned ints).
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel