[Xen-devel] [PATCH] Fix leak in blkback initialization

[glommer@xxxxxxxxxx (Glauber de Oliveira Costa)]

In case of failing due to lack of memory in the system, blkif_init
potentially leaves a leak if some of the allocations was sucessfully
suceeded.

This patch frees the memory allocated, avoiding the leak.

Signed-off-by: Glauber de Oliveira Costa <glommer@xxxxxxxxxx>
-- 
glommer

# HG changeset patch
# User root@kct
# Node ID 0b7920d3ca98c3c011b2756afcffb7e2c31b7d2d
# Parent  8f6d4878d02e65438dabda642d7bf84679dbd464

In case of failing due to lack of memory in the system, blkif_init
potentially leaves a leak if some of the allocations was sucessfully
suceeded. 

This patch frees the memory allocated, avoiding the leak. 

Signed-off-by: Glauber de Oliveira Costa <glommer@xxxxxxxxxx>

diff -r 8f6d4878d02e -r 0b7920d3ca98 
linux-2.6-xen-sparse/drivers/xen/blkback/blkback.c
--- a/linux-2.6-xen-sparse/drivers/xen/blkback/blkback.c        Tue Jan  3 
19:01:55 2006
+++ b/linux-2.6-xen-sparse/drivers/xen/blkback/blkback.c        Wed Jan  4 
13:55:33 2006
@@ -540,6 +540,9 @@
        pending_vaddrs        = kmalloc(sizeof(pending_vaddrs[0]) *
                                        mmap_pages, GFP_KERNEL);
        if (!pending_reqs || !pending_grant_handles || !pending_vaddrs) {
+               kfree(pending_reqs);
+               kfree(pending_grant_handles);
+               kfree(pending_vaddrs);
                printk("%s: out of memory\n", __FUNCTION__);
                return -1;
        }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel