Re: [Xen-devel] Clean dirty code avoiding warning messages when compiling

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>]

On Wed, Jan 18, 2006 at 04:58:06PM +0800, Xue, Haifeng wrote:
> Clean dirty code avoiding warning messages when compiling
> 
> Signed-off-by: Haifeng Xue <haifeng.xue@xxxxxxxxx>
>
> -    if (!xs_write(xs, NULL, path, pts, strlen(pts))) {
> +    if (!xs_write(xs, (xs_transaction_t)NULL, path, pts, strlen(pts))) {

Please don't override the type checking with cast to shut up gcc !
The warning is there for a reason, it should be XBT_NULL instead of NULL.

-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel