Re: [Xen-devel] [PATCH] Pin vcpu for VMX domain

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 8 Feb 2006, at 09:28, Jiang, Yunhong wrote:

> The patch fixed pin-vcpu issue for VMX domain.
> The __vmpclear should be done on the last_launch LP. It also migrate 
> the timers for vmx domain.
>  
>
> Signed-off-by: Yunhong Jiang yunhong.jiang@xxxxxxxxx
> Signed-off-by: Eddie Dong eddie.dong@xxxxxxxxx
You don't need to __vmpclear at the time the affinity is changed. You 
can still do it from within arch_vmx_do_resume() -- it is valid to call 
smp_call_function() there. That avoids having yet another HVM function, 
and avoids calling yet another arch_* function from common code.
Rather than calling vmx_remove_timers() from your SMP call function, 
can you not just call it from vmx_reinstall_timers()? You explain why 
the pit and hlt timers do not need to be re-activated in 
vmx_reinstall_timer() -- what about the APIC timer?
There's no need to check active_timer() before calling stop_timer() -- 
stop_timer does the check for you.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel