[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Repost - xm lists display and formatting




xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 02/17/2006 02:54:21 PM:

> Stefan
> Hi
> Thanks for the xm-text initiative.
>
> Did you test with xm-test (the whole suite of testx) on i386 and/or
> x86_64 and/or VMX, before submitting the patches? Did they all work?


I had tested it with xm-test 'block-list' on x86. There were no failures on those block-device related test, but 8 PASSes. This time it got stuck in one of the test.


>
> Dan is right, the doc also needs work.


I have just adapted the man page and will submit that later.

   Stefan

>
> woody
> ==============
> On Fri, 2006-02-17 at 11:00 -0800, Daniel Stekloff wrote:
> > On Fri, 2006-02-17 at 10:41 -0800, Ewan Mellor wrote:
> > > On Fri, Feb 17, 2006 at 11:22:42AM -0500, Stefan Berger wrote:
> > >
> > > > This patch displays the network-list/block-list/vtpm-list using the 'xm'
> > > > command. It supports the '--long' option.
> > > >
> > > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
> > >
> > > Applied, thank you.
> > >
> > > This will break xm-test.  Does anyone fancy fixing it up?  The
> > > least-effort thing to do is change all of the calls to block-list and
> > > network-list to become block-list --long and network-list --long, but
> > > it would be better if we fixed the eyecatchers (where necessary) to work
> > > with the new, formatted commands, and maybe added a few tests for
> > > xyz-list --long as well.
> > >
> > > And of course it would be nice to have tests for vtpm-list
> (after detecting
> > > the presence of appropriate hardware, I guess).
> > >
> > > Any volunteers?
> >
> >
> > Hi,
> >
> > Three comments:
> >
> > 1) Changes like those introduced by this patch should be submitted with
> > corresponding tests in xm-test. We want to continue to use xm-test to
> > verify functionality.
> >
> > 2) The documentation - like man pages - should be updated along with the
> > new functionality.
> >
> > 3) xm-test should be used to verify patches prior to submitting and
> > applying.
> >
> > Thanks,
> >
> > Dan
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> >
> --
> Sincerely,      Woody Marvel
> IBM Linux Technology Center
> Open Source Virtualization
> email: marvel@xxxxxxxxxx
> 503-578-3833   Beaverton, OR 97006
> **********************************
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.