[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] phys_basetab might be used uninitialized in domain.c


  • To: "Guillaume Thouvenin" <guillaume.thouvenin@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Wed, 22 Feb 2006 20:00:26 +0800
  • Delivery-date: Wed, 22 Feb 2006 12:14:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcY3no7QQIIbHgh1Rki0uXQb36lYJAAANHsQ
  • Thread-topic: [Xen-devel] phys_basetab might be used uninitialized in domain.c

>Hello,
>
> In xen-unstable [changeset 8920], gcc warns me that phys_basetab
>variable might be used uninitialized in arch/x86/domain.c
>
> So is it ok to write:
>
>    414     if ( shadow_mode_refcounts(d) )
>    415     {
>    416         if ( 
>!get_page(mfn_to_page(phys_basetab>>PAGE_SHIFT), d) )
>    417         {
>    418             destroy_gdt(v);
>    419             return -EINVAL;
>    420         }

phys_basetab should be initialized to INVALID_MFN, and check if it is
valid before use.
Also, this code causes AP of SMP VMX guest can't boot, I will send a
fix.
thanks
-Xin

>
> in arch_set_info_guest() knowing that phys_basetab can be 
>unset at this
>point.
>
>Hope this help,
>Guillaume
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.