Re: [Xen-devel] [PATCH] don't require ebtables in the host kernel

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Wed, Feb 22, 2006 at 10:54:51AM +0200, Avi Kivity wrote:

> The network-bridge script fails when setting a few sysctls
> which are only available if ebtables is present in the host
> kernel. Fix by ignoring the return value of the sysctl command.
> 
> Signed-off-by: Avi Kivity <avi@xxxxxxxxxxxx>
> 
> Index: xen/tools/examples/network-bridge
> ===================================================================
> --- xen/tools/examples/network-bridge (revision 991)
> +++ xen/tools/examples/network-bridge (revision 992)
> @@ -158,9 +158,9 @@
> 
>     # Don't create the bridge if it already exists.
>     if ! brctl show | grep -q ${bridge} ; then
> -     sysctl -w "net.bridge.bridge-nf-call-arptables=0"
> -     sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
> -     sysctl -w "net.bridge.bridge-nf-call-iptables=0"
> +     ! sysctl -w "net.bridge.bridge-nf-call-arptables=0"
> +     ! sysctl -w "net.bridge.bridge-nf-call-ip6tables=0"
> +     ! sysctl -w "net.bridge.bridge-nf-call-iptables=0"
>       brctl addbr ${bridge}
>       brctl stp ${bridge} off
>       brctl setfd ${bridge} 0

Where did this network-bridge script come from?  The stock Xen-3.0
network-bridge doesn't have these sysctl lines in the first place.

Furthermore, using ! doesn't ignore the return value -- it inverts it.  I'd be
surprised if this works in systems that _do_ have ebtables.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel