[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [RFC, PATCH 3/24] i386 Vmi interface definition

Christoph Hellwig wrote:
On Mon, Mar 13, 2006 at 10:01:14AM -0800, Zachary Amsden wrote:
Master definition of VMI interface, including calls, constants, and
interface version.

This is a totally horrible style.  There's absolutely no need to find
your own sized integer types, please use the standard kernel ones.
Also don't use camel case and #pack but rather __attribute__.
Also please avoid // comments.

Also please remove all the historical version garbage, we don't care about

Ugly, isn't it. The collision of two source styles has left some scars. And fixing it is not yet finished. We know about these problems, and we are working on getting rid of them. The historical version garbage is rather important to us internally, and these bits are not yet fully polished, so you get to see it to. I think you'll find us respecting Linux conventions a lot more in the later patches.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.