Re: [Xen-devel] RE: patch to test vbd loopback sharing issue

[Dan Smith <danms@xxxxxxxxxx>]

PY> Daniel, Thanks a lot for your patch. In fact, I have another
PY> solution for this problem, that is, we can force mode "w" to
PY> "r". I have tested this patch and it works quite well in today's
PY> xm-test report.  Please help me review this patch. :-)

AFAIK, qemu-dm does not honor the read-only flag from xend.  This has
a side effect of making the concurrent use checks go away, but it also
would indicate to someone that the disk image is read-only, which
would not be true.  So, since 'r' is not honored, 'w!' is more
appropriate, as it describes what is actually happening.

So, IMHO, Dan's patch should go into the tree.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

Attachment: pgpENyE0QAcgT.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel