[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [Xen-changelog] Fix the implicit declaration of function `swiotlb_init' warning, by including

On Tue, Mar 21, 2006 at 07:53:57PM +0000, Ewan Mellor wrote:
> Why, dare I ask?

There are two conventions here: no #ifdefs in C files if possible, and
#include <linux/xxx> comes before #include <asm/xxx>. The first one
helps readability and maintainability, the second one helps
readability and stems from letting arch specific include files
overrride generic include files.

But really, it's just the accepted kernel idiom, and if we want
upstream inclusion, it pays to play by the rules.

Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.