[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] minor Makefile fix

The patch below prevents a stray error message in the case that either
DISTDIR or DESTDIR is empty, by preventing readlink from being called
in that case.

Another option would be to use readlink -s, but that has the
undesirable effect of staying silent in situations other than empty

Signed-off-by: Aron Griffis <aron@xxxxxx>

diff -r 9afd25b90af4 tools/examples/Makefile
--- a/tools/examples/Makefile   Mon Mar 20 09:56:58 2006 -0700
+++ b/tools/examples/Makefile   Tue Mar 21 16:53:04 2006 -0500
@@ -38,8 +38,8 @@ UDEV_RULES_DIR = /etc/udev
 UDEV_RULES_DIR = /etc/udev
 UDEV_RULES = xen-backend.rules

-DI = $(shell readlink -f $(DISTDIR))
-DE = $(shell readlink -f $(DESTDIR))
+DI = $(if $(DISTDIR),$(shell readlink -f $(DISTDIR)),)
+DE = $(if $(DESTDIR),$(shell readlink -f $(DESTDIR)),)
 ifeq ($(findstring $(DI),$(DE)),$(DI))
 HOTPLUGS=install-hotplug install-udev

Attachment: pgpk9Djm4REfv.pgp
Description: PGP signature

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.