[Xen-devel] Re: [RFC PATCH 31/35] Add Xen grant table support

[Chris Wright <chrisw@xxxxxxxxxxxx>]

* Arjan van de Ven (arjan@xxxxxxxxxxxxx) wrote:
> 
> > + * This file may be distributed separately from the Linux kernel, or
> > + * incorporated into other software packages, subject to the following 
> > license:
> 
> please again fix the license

*nod*

> > +EXPORT_SYMBOL(gnttab_grant_foreign_access);
> > +EXPORT_SYMBOL(gnttab_end_foreign_access_ref);
> > +EXPORT_SYMBOL(gnttab_end_foreign_access);
> > +EXPORT_SYMBOL(gnttab_query_foreign_access);
> > +EXPORT_SYMBOL(gnttab_grant_foreign_transfer);
> > +EXPORT_SYMBOL(gnttab_end_foreign_transfer_ref);
> > +EXPORT_SYMBOL(gnttab_end_foreign_transfer);
> > +EXPORT_SYMBOL(gnttab_alloc_grant_references);
> > +EXPORT_SYMBOL(gnttab_free_grant_references);
> > +EXPORT_SYMBOL(gnttab_free_grant_reference);
> > +EXPORT_SYMBOL(gnttab_claim_grant_reference);
> > +EXPORT_SYMBOL(gnttab_release_grant_reference);
> > +EXPORT_SYMBOL(gnttab_request_free_callback);
> > +EXPORT_SYMBOL(gnttab_grant_foreign_access_ref);
> > +EXPORT_SYMBOL(gnttab_grant_foreign_transfer_ref);
> 
> and consider these as _GPL exports

Yes, I meant to note that as one of the known issues.  License clarity
and _GPL exports.

> > +#ifndef __ia64__
> > +static int map_pte_fn(pte_t *pte, struct page *pte_page,
> > +                 unsigned long addr, void *data)
> > +{
> > +   unsigned long **frames = (unsigned long **)data;
> > +
> > +   set_pte_at(&init_mm, addr, pte, pfn_pte((*frames)[0], PAGE_KERNEL));
> > +   (*frames)++;
> > +   return 0;
> > +}
> 
> looks to me the wrong ifdef for a file in arch/i386... please fix

Yes, the reuse of grant table amongst each Xen supported architecture
suggests it's in the wrong location.

thanks,
-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel