[Xen-devel] Re: signed-off-by process

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Sunday 26 March 2006 05:40, Xen patchbot -unstable wrote:
> # HG changeset patch
> # User kaf24@xxxxxxxxxxxxxxxxxxxx
> # Node ID 38c170be0e637717305179a8b32090d2ada54907
> # Parent  11fee62328cc1697d7c140bf27635d184362bce5
> Add format printf attribute to panic() prototype and fix the error  
> this catches.
> 
> Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
> Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

Hi Keir, since you modified Jimi's patch, this is not in keeping with 
paragraph (c) of the Developer Certificate of Origin 
(http://www.osdl.org/newsroom/press_releases/2004/2004_05_24_dco.html).

If you don't like a submitted patch as-is, I think the options are either:
a) ask the original author to resubmit the patch
b) check in the patch unmodified, then check in your modifications afterwards

In most cases, a) is probably preferable.

> diff -r 11fee62328cc -r 38c170be0e63 xen/arch/x86/traps.c
> --- a/xen/arch/x86/traps.c    Fri Mar 24 16:48:03 2006
> +++ b/xen/arch/x86/traps.c    Sun Mar 26 10:35:11 2006
> @@ -705,7 +705,7 @@
>          panic("CPU%d FATAL PAGE FAULT\n"
>                "[error_code=%04x]\n"
>                "Faulting linear address: %p\n",
> -              smp_processor_id(), regs->error_code, addr);
> +              smp_processor_id(), regs->error_code, _p(addr));
>      }
>  
>      propagate_page_fault(addr, regs->error_code);
> diff -r 11fee62328cc -r 38c170be0e63 xen/include/xen/lib.h
> --- a/xen/include/xen/lib.h   Fri Mar 24 16:48:03 2006
> +++ b/xen/include/xen/lib.h   Sun Mar 26 10:35:11 2006
> @@ -47,7 +47,8 @@
>  #define printk(_f , _a...) printf( _f , ## _a )
>  extern void printf(const char *format, ...)
>      __attribute__ ((format (printf, 1, 2)));
> -extern void panic(const char *format, ...);
> +extern void panic(const char *format, ...)
> +    __attribute__ ((format (printf, 1, 2)));
>  extern long vm_assist(struct domain *, unsigned int, unsigned int);
>  
>  /* vsprintf.c */
> 
> _______________________________________________
> Xen-changelog mailing list
> Xen-changelog@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-changelog
> 
> 

-- 
Hollis Blanchard
IBM Linux Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel