[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [RFC PATCH 07/35] Make LOAD_OFFSET defined by subarch

On Tuesday 28 March 2006 02:49, Gerd Hoffmann wrote:
> > This makes me a little nervous, since the ELF loading code is working fine 
> > PPC at the moment. What exactly are you planning on changing?
> Basically what the suggestion outlined: use physical address + VIRT_BASE
> instead of placing virtual addresses into the physical address fields.
> Some discussions on that went over the list some weeks ago.  Patch
> attached for reference.

> +         * bug comparibility alert: old linux kernels used to have
> +         * virtual addresses in the paddr headers, whereas newer ones
> +         * (since kexec merge, around 2.6.14) correctly use physical
> +         * addresses.

("comparibility" -> "compatibility")

I can't speak for IA64, but PPC kernels still have virtual addresses in the 
paddr fields. Accordingly, I would reword it like this:
        Some Linux kernels have virtual addresses in the paddr headers, and some
        correctly use physical addresses.

Please CC xen-ppc-devel (and probably xen-ia64-devel) when you submit the 
patch so we can make sure this logic works for PPC. Thanks!

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.