[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vnet-module

Mike Wray schrieb:
Robert Valentan wrote:

  Replacing the socketcall with direct calling the needed
  functions (my patch from 28.3)

I don't like the idea of pasting all this code copied from elsewhere in
the kernel.
If the problem is that __ARCH_WANT_SYS_SOCKETCALL is not defined, so
there is no socketcall, then a better solution needs to be found.

x86_64 definies __ARCH_WANT_SYS_SOCKETCALL, but has no entry-point for
it. A better solution will be an export of the needed functions in
net/socket.c ...  But where to get it ?

In the worst case a copy of the relevant bits of socket.c defining socketcall
in a separate file with an #ifndef __ARCH_WANT_SYS_SOCKETCALL round it.

I havn't take a separate file, because my solution will also work for
the other systems. If you want a separate file, i will modify my patch,
but we need a permanent include, or need to use "__NR_socketcall"..

  Modify the module-parameter for kernel 2.6.* (the old one
  will not compile with the actual kernel 2.6.16)
  Exporting the default-values of the parameters in /sys/module

  Some "extentions" to error-messages to identify the position
  in the code.
  I had searched a bug, but it was a wrong vnet-id ;-/
  A hint for docu: using "123459" as vnet-id has not 4 digits
  and will be punished with errors  ;-)

The changes to the print functions are not needed - the debug macros
in the code already include the function name. All you need to do
is #define DEBUG 1. Check libxutil/debug.h. for the definitions.

Ohh..  thank you for the hint ;-/

Robert Valentan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.