[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] add support for XCHG instruction accessingAPIC




On 5 Apr 2006, at 17:50, Jiang, Yunhong wrote:

I think the reason we don't take any lock here is; we are sure this is just used for local APIC range. However, if in future someone adds another MMIO range or if IOAPIC is accessed with XCHG (will this happen?), this may have potential issue.

So I'd suggest adding comments that we didn't take any lock here, or add a check to make sure the range is on local APIC range.

There is a comment in the patch I applied, and that section of code is specific to LAPIC handling.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.