Re: [Xen-devel] [PATCH 0/6] grantable and address conversion patches

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 10 Apr 2006, at 09:32, Isaku Yamahata wrote:
> The following patch series are necessary for xen/ia64 VP model.
> Although I tested only compiling and booting dom0 on xen/x86_32,
> I believe the patches don't break existing xen/x86.
>
> Xen/IA64 developers have been working on getting vnif, balloon driver
> to work. The results of the effort are the series of patches called
> the P2M/VP model patches. (They aren't finished yet though.)
> Especially grant table and domain address conversion are the issues.
> Some of the common files need to be patched for the issues.
Comments:

1/6: We can't apply this as it would change the public 3.0 interface 
for x86/64. Do you really need a long? If so, we'll have to make that 
field arch-dependent in some way.
2/6: This is a poor fix. Either we should make the ring size fixed 
(e.g., 4kB) rather than architectural page-sized, or grants should be 
dynamically allocated in netfront rather than statically allocated. 
This was done quite some time ago for blkfront, and would be the 
preferred (although more difficult) fix here.
3/6: No, let's just take another bit and stop using PG_arch_1 
altogether. We can thrash out which is the 'best bit' to take when the 
patches are posted upstream.
4/6: Make the function that fills in map/unmap requests arch-specific? 
At least filling in host_addr should be arch-specific -- we don't 
really want to overload dev_bus_addr like this.
5/6: This looks acceptable.

6/6: Understood that it's not for checking in, but it looks kind of 
scary anyhow. :-)
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel