[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().


  • To: "James Morris" <jmorris@xxxxxxxxxx>
  • From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
  • Date: Thu, 13 Apr 2006 06:29:12 +0800
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 12 Apr 2006 15:29:40 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcZeaUKdgSFuTDBCSkaoE5n3L5uWtQAFytOQ
  • Thread-topic: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().

>> Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx>
>> 
>
>> +            if ( v->arch.shadow_vtable )
>> +                    unmap_domain_page_global(v->arch.shadow_vtable);
>> +                v->arch.shadow_vtable = NULL;
>
>Why not:
>
>               if ( v->arch.shadow_vtable ) 
>               {
>                       unmap_domain_page_global(v->arch.shadow_vtable);
>                       v->arch.shadow_vtable = NULL;
>               }
>

Yes, this is better :-),
thanks
-Xin

>
>-- 
>James Morris
><jmorris@xxxxxxxxxx>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.