[Xen-devel] [PATCH] fix x86_64 builds that explicitly specify XEN_TARGET_ARCH

[David Lively <dlively@xxxxxxxxxxxxxxx>]

Trivial patch to fix x86_64 builds in which XEN_TARGET_ARCH
is specified on the make command line, e.g.:
    make XEN_TARGET_ARCH=x86_64

This busted the vmxassist and hvmloader builds, which must
be done -m32.  Using "override" in the vmxassist/hvmloader
Makefiles fixes the problem by not allowing this to be
overridden from the command line.

Signed-off-by: Dave Lively <dlively@xxxxxxxxxxxxxxx>

# HG changeset patch
# User lively@dlively2
# Node ID 70fde73c168c7d0c6188882f4f05451ae6136a24
# Parent  2a6dbd9efc9dbea4ce4f5b9bdace87df3f19a55c
Fix x86_64 builds that specify XEN_TARGET_ARCH explicitly
on the make command line.  (We must build hvmloader and
vmxassist for x86_32 even in this case.  Now we don't let the
assignment that does this get overridden by the command-
line arg.)

diff -r 2a6dbd9efc9d -r 70fde73c168c tools/firmware/hvmloader/Makefile
--- a/tools/firmware/hvmloader/Makefile Tue Apr 11 15:53:00 2006 -0400
+++ b/tools/firmware/hvmloader/Makefile Thu Apr 13 10:24:54 2006 -0400
@@ -21,7 +21,7 @@
 # External CFLAGS can do more harm than good.
 CFLAGS :=
 
-XEN_TARGET_ARCH = x86_32
+override XEN_TARGET_ARCH = x86_32
 XEN_ROOT = ../../..
 include $(XEN_ROOT)/Config.mk
 
diff -r 2a6dbd9efc9d -r 70fde73c168c tools/firmware/vmxassist/Makefile
--- a/tools/firmware/vmxassist/Makefile Tue Apr 11 15:53:00 2006 -0400
+++ b/tools/firmware/vmxassist/Makefile Thu Apr 13 10:24:54 2006 -0400
@@ -21,7 +21,7 @@
 # External CFLAGS can do more harm than good.
 CFLAGS :=
 
-XEN_TARGET_ARCH = x86_32
+override XEN_TARGET_ARCH = x86_32
 XEN_ROOT = ../../..
 include $(XEN_ROOT)/Config.mk
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel