Re: [Xen-devel] Oops from loop driver on IA64

[Muli Ben-Yehuda <muli@xxxxxxxxxx>]

On Tue, Apr 18, 2006 at 07:41:55PM +0900, Kouya SHIMURA wrote:

> I investigated this and might find a serious bug.
> On x86, flush_dcache_page() does nothing and there is no problem.
> But on ia64 flush_dcache_page() might access a wrong page struct
> and destroy the kernel memory.
> 
> Attached patch fixes this problem but it seems bad idea to modify
> a linux driver. How should we fix it?

Adding ifdefs to drivers is definitely not the right thing do do from
an upstream inclusion point of view. Can you define
flush_dcache_page() to be a NOP or some other reasonable definition
when running under Xen?

Cheers,
Muli

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel