Re: [Xen-devel] [PATCH] linux: xenbus_be currently doesn't build properly as a module

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 20 Apr 2006, at 13:11, Jan Beulich wrote:

> It depends on the non-exported symbols vmlist and vmlist_lock. As 
> exporting these doesn't seem reasonable, the patch
> disables the ability to build this as a module for now.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
A better fix is for xenbus_map_ring_valloc() to have the prototype:
struct vm_struct *xenbus_map_ring_valloc(struct xenbus_device *, int);

It then returns the vmarea that is allocated, or ERR_PTR() on error.

Then xenbus_unmap_ring_vfree() takes the vmarea rather than vaddr and 
we avoid the nasty vmlist scan that cannot be modularised.
There's only one user of these functions right now, so the patch for 
this proper fix won't be very big.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel