Re: [Xen-devel] [PATCH] - return error when appropriate from increase_memory_reservation

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 20 Apr 2006, at 19:04, Ben Thomas wrote:

> This patch fixes a case in increasing a memory reservation where you
> do not get the pages nor do you get an error.  While an argument might
> be made that checking the page count independently is workable, it
> does seem reasonable to have the operation return a failure in the
> cases where it doesn't do what was asked. Right now, it mostly returns
> the correct status.  This patch just adds another instance of this.
No. In cases where it fails it does not undo its partial work. The 
current return lets the caller know how much work was done so that 
appropriate action can be taken. The callers need fixing -- there 
aren't that many. Only increase_reservation or populate_physmap can 
fail, unless the caller is buggy, so they are the only ones that really 
need fixing. The others should probably BUG_ON() or assert or print an 
error in the caller though.
> And, while-I-was-there, I've been generating linker maps for qemu in
> my own builds. It's harmless, until you need it and then it's valuable.
> Tweak the Makefile to create the map.
I'll take that as a separate patch.

 Thanks,
 Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel