Re: [Xen-devel] [PATCH] pci-dma-xen.c change necessary for xen/ia64

["Christian Limpach" <christian.limpach@xxxxxxxxx>]

On 4/25/06, Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:
> xenLinux/ia64 with dom0 vp model uses
> linux-2.6-xen-sparse/arch/i386/kernel/pci-dma-xen.c.
> But it has its own dma_map_page(), dma_declare_coheremnt_memory() and their
> families. So those in pci-dma-xen.c are unnecessary. #ifdef out them.
Does this work?  If you have your own dma_declare_coherent_memory(),
don't you then need to #define ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY so
that you don't get the default implementations in linux/dma-mapping.h?

I also don't like the ifdef on dma_map_page since it requires you to
#define it to something else to override it instead of implementing
it.

I prefer to have #if defined(__i386__) || defined(__x86_64__) (maybe
with a comment stating !defined(__ia64__)) which will make it clear 
why these are ifdef'ed out.
I think this approach is ok for now since we haven't decided whether
to merge this file back into i386' pci-dma or move it to
drivers/xen/core.

    christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel