[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] initialize some more cpuinfo fields




On 8 May 2006, at 15:18, Jan Beulich wrote:

If the many-core appearance is a problem then we could synthesise
different physical IDs for VCPUs (probably by forcing physical ID to
VCPU number).

This is what the patch does (it simply overrides whatever identify_cpu() provided).

Why add the copy from boot_cpu_data, or the call to identify_cpu(), at all? We already initialise the cpu_data in smp_prepare_cpus(), and we set up the cpu_to_apicid array at the same time. Why not lie about cpu_data->apicid, and set phys_proc_id[cpu], at the same time in the same function?

That would be a one- or two-liner, plus maybe your modification of booted_cores if that's still needed.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.