[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] [vTPM] Not building vTPM frontend as module



Even if it is unsafe to unload the module, there is still enormous 
benefit in allowing to build as a module as it allows the user to 
choose whether or not to load it in the first place!
I suggest you add __unsafe(THIS_MODULE) to the end of your module_init 
function, as we have done for netback and blkback. This will make it 
impossible for the user to unload the module, and print a message to 
the kernel log explaining why.
I'll apply the hunk of your patch that fixes the backend issue however.

 -- Keir

On 9 May 2006, at 18:08, Stefan Berger wrote:

This patch prevents the vTPM frontend to be built as module for now. An
'rmmod' causes some problems since the backend is still using the shared
page.
This patch also fixes a problem in the backend.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>


<tpm_module.diff>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.