[Xen-devel] Re: [RFC PATCH 17/35] Segment register changes for Xen

[Andi Kleen <ak@xxxxxxx>]

On Thursday 11 May 2006 12:34, Avi Kivity wrote:
> Pavel Machek wrote:
> > Really? If someone does 
> >
> >     if (something)
> >             clearsegment(seg)
> >     somethingelse();
> >
> > ... he'll get very confusing behaviour instead of compile error. 
> >
> > Okay, that's weaker argument than expected...
> >
> > Also clearsegment(x) clearsegment(y); will compile when it should not.
> >
> > Also clearsegment(i++) will behave strangely. So perhaps 
> >
> > #define clearsegment(seg) do { seg; } while (0)
> >   
> 
> static inline void clearsegment(int seg) {}


It's all mood because the complete function is wrongly named
and probably should just go.

-Andi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel