[Xen-devel] Re: [RFC PATCH 26/35] Add Xen subarch reboot support

[Chris Wright <chrisw@xxxxxxxxxxxx>]

* Pavel Machek (pavel@xxxxxxx) wrote:
> Hi!
> 
> > > +
> > > +/* Ignore multiple shutdown requests. */
> > > +static int shutting_down = SHUTDOWN_INVALID;
> > > +static void __shutdown_handler(void *unused);
> > > +static DECLARE_WORK(shutdown_work, __shutdown_handler, NULL);
> > > +
> > > +static int shutdown_process(void *__unused)
> > > +{
> > > + static char *envp[] = { "HOME=/", "TERM=linux",
> > > +                         "PATH=/sbin:/usr/sbin:/bin:/usr/bin", NULL };
> > > + static char *poweroff_argv[] = { "/sbin/poweroff", NULL };
> > 
> > This should be configurable, probably in a sysctl
> 
> Actually we have similar code in sparc and acpi parts, IIRC. We
> probably want to have one, common, shut-me-off routine.

Yep, I had that cleanup in mind, the patch said:

TODO:
 - move poweroff and halt to generic similar to c_a_d

thanks,
-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel