RE: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races

["Santos, Jose Renato G" <joserenato.santos@xxxxxx>]

>> > Sorry, didn't mention this earlier.  Please use new mutex 
>> code here, 
>> > smth like:
>> >
>> > s/DECLARE_MUTEX(adom_sec)/DEFINE_MUTEX(adomain_mutex)/
>> > s/down(&adom_sem)/mutex_lock(&adomain_mutex)/
>> > s/up(&adom_sem)/mutex_unlock(&admoain_mutex)/
>> >
>> > thanks,
>> > -chris
>> 
>> What about buffer_sem in drivers/oprofile/event_buffer.c and 
>> start_sem in drivers/oprofile/oprof.c?  Want me to submit a 
>> patch to convert all three?
>> 

   I think we should minimize changes to generic oprofile code
   (in drivers/oprofile) to minimize divergence from main stream linux.
   For this reason I don't think we should touch buffer_sem and
   start_sem.

   Renato

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel