Re: [Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

We did a similar patch recently here (not submitted, yet) - so I immediately 
see some concerns with your patch:

- Why do you need to add BLKGETSIZE and BLKGETSIZE64? block/ioctl.c is already 
taking care of those, they should never
arrive at the driver.
- The calculation of the cylinder value seems odd to me. Why don't you use 
sector_div() here?
- There is an apparently unused variable 'dpart' left in blkif_getgeo().

Jan

>>> Pascal Bouchareine <pascal@xxxxxxxxx> 15.05.06 20:15 >>>
Hi,

Adds HDIO_GETGEO, BLKGETSIZE, BLKGETSIZE64 support to blkfront.

An attempt to merge in the following sent previously by Ian Pratt :
http://lists.xensource.com/archives/html/xen-devel/2005-01/msg00659.html 

Taking into account the block_device_operations for get_geom.

Regards,
Pascal

-- 
\o/   Pascal Bouchareine - Gandi 
 g    0170393757           15, place de la Nation - 75011 Paris      

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel