Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 16 May 2006, at 13:57, Andi Kleen wrote:

> > Yes, my gut feeling looking at x86_64's numa.c is that it's going to
> > need some heavier surgery than srat.c. I wouldn't worry so much about
> > keeping that one close to the Linux original: if we end up pulling 
> > down
> > more Linux memory bookkeeping code later then we can always go back 
> > and
> > sync the file more closely. Keep it as clean as possible though,
> > obviously (e.g., replacing whole functions is nicer than functions 
> > that
> > are a hacky halfway house between Linux and Xen, etc).
> If it helps I can split these functions into smaller ones in the 
> mainline
> sources. That could isolate the pglists in only very small functions.
Thanks: I guess we'll see how the new patch turns out. It would 
certainly be very useful if you could glance over the next revision of 
the NUMA patches -- at least the first one of the set which will be the 
one that takes code from x86/64 Linux. I'm certain you'll be able to 
pick up on details that I wouldn't spot.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel