Re: [Xen-devel] [PATCH] (corrected) 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Tue, May 23, 2006 at 03:40:14PM -0500, Paul Larson wrote:

> On Tuesday 23 May 2006 14:49, Ryan Harper wrote:
> > * Paul Larson <pl@xxxxxxxxxx> [2006-05-23 14:33]:
> > > If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not
> > > get restored causing subsequent boots to come up with only a single vcpu
> > > on dom0.
> >
> > Though I've never seen this mentioned on the list, I thought we wanted
> > to leave the system in the failed state if a test failed?  That's
> > certainly debatable.  Thoughts?
> Generally, that's probably a good rule but in this case it's better to go 
> with 
> the FAIL() output and put it back to a reasonable state because  the altered 
> state can persist not only out the end of the test run, but across xend 
> restarts and even reboots.  The reason this came up is because a bug was 
> filed where a few systems were only showing one cpu in /proc/cpuinfo, but 
> they were configured for smp and had previously booted with all their 
> processors.
> 
> > White-space damage.
> Doh! Fixed version attached.
>  01_enforce_dom0_cpus_basic_pos.py |   21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> Signed-off-by: Paul Larson <pl@xxxxxxxxxx>

Applied, thank you.

Ewan.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel