Re: [Xen-devel] shared_info setup

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 2 Jun 2006, at 15:18, Jan Beulich wrote:

> Isn't the comparison in the two places where HYPERVISOR_shared_info 
> gets set up wrong in comparing a machine (=physical)
> address to a page count? I.e., shouldn't either it or nr_pages be 
> shifted by PAGE_SHIFT? Jan
I think so. But I think actually the place that sets up without using 
fixmap could probably be got rid of -- although in that case there is 
no need to use fixmap, since we have the fixmap entry and the code to 
fill it in, we may as well do that in all cases.
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel