[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [patch] ACM ops interface

On 8 Jun 2006, at 19:32, Hollis Blanchard wrote:

First, it isn't using XEN_GUEST_HANDLEs where it should (i.e. when
pointers in the interface). What's a little scary is that because
using void* everywhere, we didn't get any compiler warnings (if
passing buffers, maybe 'unsigned char *' would be a better type?).

Keir responded to this point already

I didn't see that, actually.

Yeah, I don't think I did.

Anyway, should I take Hollis's patch or do you want it worked on some more?

As for copy_to/from_user sleeping, they don't sleep in Xen but it would be nice to avoid putting it in a locked region anyway in case we want to do anything clever in future. I may start asserting that in debug builds.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.