[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Blktap: Userspace file-based image support. (RFC)

  • To: "Anthony Liguori" <aliguori@xxxxxxxxxx>
  • From: "Andrew Warfield" <andrew.warfield@xxxxxxxxxxxx>
  • Date: Mon, 19 Jun 2006 12:31:42 -0700
  • Cc: Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>, Julian Chesterfield <julian.chesterfield@xxxxxxxxxxxx>
  • Delivery-date: Mon, 19 Jun 2006 12:32:04 -0700
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ibGNfOM9U9E6N2xpEYtebMmRutBsslYnkP1pUkGryx6UFZyI3zrFoipFR+SOqK1DOEQ+QVeUlyZQKX1xoLeFmtkC8189nN0ujgcSQm3q526PXJP3O03x963G7HtPSET4MEdCu589ArFQWOWXJl7hjZ7dSguAL9owE1n1u4gkYSQ=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Excellent comments, thanks.

Please don't introduce more (ab)uses of /proc.  Sure it's just for
debugging but there's no reason to not make that sysfs.

I'm not an expert here, but the nopage handlers that I've seen return
NOPAGE_SIGBUS instead of manually causing a SIGBUS on current.

I think it's better to use C99 initialization than GCC:

  owner:  ...,  =>  .owner = ...,

Some of the indenting is a bit off from Linux CodingStyle.  Stuff like
if( => if ( and some random spaces after an (.

There's some code commented out with C++ comments too.

All good -- I'll take a pass through and fix all these this week.

What's the significance of /**BLKTAP**/ and /**TAPEND**/?

For a while we were maintaining the kernel tap driver as a diff
against blkback, to pick up fixes quickly -- those markers were just
to mark differing regions.  I think the current code has diverged
enough to make this approach untenable.

I'm a little surprised to see these conversion tools too.  Wouldn't it
be easier to just add some parameters to qemu-img?

The image tools use our plugins (rather than qemu's) to build disks --
most importantly they adjust the layout to build better-performing
images.  Fair point though, I think julian was going to look and see
if we could get away with just using the qemu tools.

Pretty interesting stuff, thanks for posting.

Thanks for the feedback!


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.