[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [patch] load 64-bit files with 32-bit tools

On 20 Jun 2006, at 02:22, Anthony Liguori wrote:

I believe that on x86-64 uint64_t is defined to be unsigned long.

I think the proper (albeit ugly) thing to do here is use PRIu64.

Or change the _p() macro to cast to void* via long. Then we continue to print in the same format we always have for 32-bit x86 guests. Makes the patch a bunch smaller too.

My main concern with this patch is whether, by using a wider type, it breaks any of the address-wrapping validation checks we added. On first glance it looks okay though.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.