[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] Output Virtual Block Device requests information to /proc/xen/vbd

  • To: "Satoshi Uchida" <s-uchida@xxxxxxxxxxxxx>
  • From: NAHieu <nahieu@xxxxxxxxx>
  • Date: Thu, 22 Jun 2006 01:13:21 +0900
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 21 Jun 2006 09:13:46 -0700
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=r9OZMH1R5EHdS4W/CUPNCDtarYr7tnRpAsuBviLbc2TmT9fJ4xcbcMxjUPoXzPjGlSiBc3Wp1Ma0eIGxqQdE3DAJM8Jjx21FlXXFAHejXBH5Y4/u5b4+qFs5KOhXLwuqvS4VvTD6aGP53U2N1z8OpKI+tLwlOYd4zspMJJ/m2Pc=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>


I looked at the code, and it seems "oo" stands of "out of", which
indicates how much we were out of request (Xen supports up to 64
requests in queue)

Few minor comments:
- The variable dom_io_info_wq is unused, should be removed.
- printk("%s: out of memory\n", __FUNCTION__) should be used with KERN_ERR

I have one question: in your below output:

Domain 4 - oo        0  rd    18699  wr        2
 xvd 4  8:21 - oo        0  rd    18699  wr        2

I notice that you output the domid with xvd (4), but in the above
line, we already had that information (Domain 4). So why you need to
show the domid again?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.