[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] fix linux ioremap() of domain local memory

Avi Kivity wrote:
is_local_lowmem() treats its physical address input as a machine address; this causes agpgart to fail while calling ioremap_nocache().

X still does not load on my Athlon 64 / Via S3 Unichrome, so perhaps best not to apply just yet.

This is bogus: ioremap_nocache() does accept machine addresses, but x86_64 agpgart passes it a physical address. This is because x86_64 lacks the address translation bits:

--- /dev/null   2006-06-25 13:08:55.714359750 +0300
+++ include/asm-x86_64/mach-xen/asm/agp.h       2006-06-25 13:15:12.000000000 
@@ -0,0 +1 @@
+#include "../../../asm-i386/mach-xen/asm/agp.h"

Still locks up hard when starting up X, but now the gart table is remapped correctly at least.

error compiling committee.c: too many arguments to function

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.