[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH]hvm guest ACPI dynamic initialization

Indentation/formatting/spelling is all over the place in this patch, and needs fixing (e.g., use hard/soft tabs to match surrounding code). I'm not an ACPI expert -- you'll also need to explain more clearly what the patch fixes and how.

 -- Keir

On 23 Jun 2006, at 17:59, Wang, Winston L wrote:

Attached please see the hvm guest ACPI dynamic initialization update:
1. Adding dynamic USB bridge number...,  so  ACPI FADT table's ACPI HW
register base pointer will no longer need to be changed.
2. No need to have USB support (USB=1 and usbdevice='device' ) switches
in guest configuration to enable proper ACPI support.
3. ACPI PCI bridge will be init only on  acpi=1 is set in guest
4. Minor issue is fixed in PIC mode _PRT table for PCI device 4( we
don't have the such a device yet, fix it now for the future blow up).
5. The patch is tested on acpi=0/1;usb=0/1, smp/up Linux guest, Windows
XP/2003 installation/boot, those all 16 combination cases.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.