[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] FW: Is it a correct place for VBD information?

On 28 Jun 2006, at 02:15, Satoshi Uchida wrote:

In Linux net/core/net-sysfs.c., the 'fmt' representation is used by statistical data.
In the other, it is used literals or define show function directly.
Therefore, representation will be not unified in detail.
(Perhaps, macro is not better in net/core/net-sysfs.c)

Using a macro for the function makes sense here, rather than duplicating a multi-line function block.

I think that it is useful for recognizing data type and interesting,
and so used fmt representation.

In Linux, "\n" is written in format even if using literals.
However, I think that above representation is interesting and
want to use idea if using literals.

Please comment, using fmt macro or literals.

Literals are clearer here. Then the macro invocations read like a printf() style of call.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.