[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] [PATCH][HVM] Removing 1:1 mapping from qemu-dm

  • To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
  • From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
  • Date: Wed, 28 Jun 2006 11:02:34 -0700
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 28 Jun 2006 11:05:45 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acaa2lx9h4XCYrhcSoqWJz8BD9CdeAAAEpzw
  • Thread-topic: [Xen-devel] [PATCH][HVM] Removing 1:1 mapping from qemu-dm

Keir Fraser wrote:
> On 28 Jun 2006, at 18:33, Nakajima, Jun wrote:
>>> I'd prefer the hack in mm.c I think. It's certainly much smaller,
>>> and it'd be okay with a comment. Is there any way for
>>> get/put_page_type to know if they've been called on a shadow page
>>> (as opposed to a guest page) and to avoid changing the type count
>>> based on that, rather than whether the page is local or foreign?
>>> That'd be a neater and less hacky thing to use for the decision imo.
>> Basically we need to tell the parent L1 (or top) page that has a
>> reference to it, for example. If it's a shadow page, the guest page
>> is being used in the shadow tree. It would be doable for
>> get_page_type, but almost impossible for put_page_type given it gets
>> only one argument (page_info) today.
> Sorry, I actually meant get/put_page_from_l1e(). Does that make the
> problem easier? I'd be prepared to add an extra parameter to those
> functions if really necessary.

That would be sensible ;-) I think we need to add an extra parameter to
those to specify the context (guest or shadow, for example) rather than
who's calling.

Intel Open Source Technology Center

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.